Skip to content

[Breaking][Refactor] multi select selected option#42

Merged
selvagsz merged 3 commits intomasterfrom
refactor/multi=select-selected-option
Apr 9, 2018
Merged

[Breaking][Refactor] multi select selected option#42
selvagsz merged 3 commits intomasterfrom
refactor/multi=select-selected-option

Conversation

@selvagsz
Copy link
Copy Markdown
Owner

@selvagsz selvagsz commented Apr 9, 2018

[Breaking] Make selectedOptionComponent in consistent with option component

Before

const CustomSelectedOptionComponent = ({ option, optionLabelPath, onCloseClick, select }) => (
  <li className="PowerSelectMultiple__SelectedOption">
    <span className="PowerSelectMultiple__SelectedOption__Label">
      <img className="flag" src={option.flag} />
      {option[optionLabelPath]}
    </span>
    <span
      className="PowerSelectMultiple__SelectedOption__Close"
      onClick={event => {
        event.stopPropagation();
        onCloseClick({ option, select });
      }}
    >
      ×
    </span>
  </li>
);

After

const CustomSelectedOptionComponent = ({ option }) => (
  <span>
    <img className="flag" src={option.flag} />
    {option.name}
  </span>
);

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 9, 2018

Coverage Status

Coverage increased (+0.4%) to 80.551% when pulling 75c1ce8 on refactor/multi=select-selected-option into 9d0e60e on master.

@selvagsz selvagsz merged commit 08c9ce9 into master Apr 9, 2018
@selvagsz selvagsz deleted the refactor/multi=select-selected-option branch April 9, 2018 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants